Skip to content

Updated evaluation function docs - #37

Merged
m-messer merged 4 commits into
mainfrom
updated-eval-fn-docs
Sep 9, 2026
Merged

Updated evaluation function docs#37
m-messer merged 4 commits into
mainfrom
updated-eval-fn-docs

Conversation

@m-messer

@m-messer m-messer commented Sep 8, 2026

Copy link
Copy Markdown
Member

Addresses #36 and provides other needed updates to the evaluation function user docs, to align with Shimmy details.

@peterbjohnson peterbjohnson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of comments. The first one is just in one place - I avoided repeating it - but overall in some places I was a bit confused by what's generic and what's python-specific.

In many places you have made it clear enough, but in a few it's not clear to me. Could you do a sweep from that perspective and see if your can make any improvements?

Separate comment: the overview of the python function is useful. We need to ensure no duplication, so the READMEs in the functions should point to this page, or vice versa. Will you/have you check(ed) that everything is consistent and with no duplication?

Finally, should we introduce a convention for what to do with the main README when a new eval function is created? Currently they all look generic - they should be changed to point at their own docs. Can we systematise that somehow? At the very least say here in these docs that it should be done?

Comment thread docs/advanced/evaluation_functions/local.md
Comment thread docs/advanced/evaluation_functions/specification.md Outdated
…fram and other languages, clarified base-layer behavior, and refined Python-centric instructions.
…ons on universal and Python specifications, and improved explanations for error handling and outputs.
@m-messer

m-messer commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Thanks for the comments, they should be addressed in the recent commit.

…r local container testing, including HTTP API usage, health checks, and µEd/Legacy request examples.
@peterbjohnson

Copy link
Copy Markdown
Member

Thanks all good. One typo I spotted: 'byt'. Otherwise, approved (can't see the button).

@m-messer
m-messer merged commit b9ee242 into main Sep 9, 2026
1 check passed
@m-messer
m-messer deleted the updated-eval-fn-docs branch September 9, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants